Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTEL_RESOURCE_ATTRIBUTES to docker compose #664

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Dec 28, 2022

Changes

This adds OTEL_RESOURCE_ATTRIBUTES to the .env file and also makes use of it across all services. This allows to easily introduce service.namespace

Merge Requirements

@svrnm svrnm requested a review from a team December 28, 2022 13:17
docker-compose.yml Outdated Show resolved Hide resolved
@julianocosta89 julianocosta89 merged commit 5d330b6 into open-telemetry:main Jan 9, 2023
@puckpuck
Copy link
Contributor

Do we want to add this to the Helm chat as well? Is this different from what we call k8s.namespace.name we already export as a resource attribute when deployed with Helm?

@puckpuck puckpuck added the helm-update-required Requires an update to the Helm chart when released label Jan 17, 2023
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* Add OTEL_RESOURCE_ATTRIBUTES to docker compose

Signed-off-by: svrnm <[email protected]>

* Update CHANGELOG.md

Signed-off-by: svrnm <[email protected]>

* Update CHANGELOG.md

* Update docker-compose.yml

Co-authored-by: Juliano Costa <[email protected]>

Signed-off-by: svrnm <[email protected]>
Co-authored-by: Juliano Costa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants